WordPress hosted theme, no thanks.

I am so glad I don’t develop themes for WordPress. rather draconian values seem to have snuck into the design process.

comment_form() needs to be used in comments.php / comments-popup.php (or relevant coding) where a comment form is created.

`function detectWPMU() {
return function_exists(‘is_site_admin’);
}`

This function just should be if is_multisite() and that particular function removed completely.

** From theme-review list
This theme also needs to use comment_form() instead of creating it’s own form, it would fail on that as well.

I’ve omitted all of the problems with the programming of this theme, Ben has already stated that he doesn’t work on this theme anymore and only updates it once in awhile to ‘make it work’; unfortunately that’s not good enough to pass the review at this time.

Let’s take this function inside core.php for example:

function detectWPMU() {
return function_exists(‘is_site_admin’);
}

… That’s so outdated it’s silly, much like the methodology used in things like the tarsky_bodyclass functions, should be used as a filter instead of

Furthermore let’s talk about ionfish how he has functions calling hooks instead of just embedding the hook in the location used .. erm.. why? .. yeah I would call that unneeded unnecessary coding.
`
function detectWPMUadmin() {
return detectWPMU() ? is_site_admin() : false;
}
`
`
return is_multisite() ? is_super_admin() : false;
`
Should also change from using the get_pages in the function _tarski_navbar_page_links to using the wordpress 3.0 menu system

the function tarski_bodyclass() isn’t retrieving the core made ones and adding them to the classes found, a filter here would be more beneficial instead of reinventing the wheel

`
function tarski_searchform() {
include_once(TEMPLATEPATH . “/searchform.php”);
}
`

should use get_search_form() instead, this is outdated and will fail the review as well

Taken directly from: http://themes.trac.wordpress.org/ticket/631

Let’s analyse some of that:

This theme also needs to use comment_form() instead of creating it’s own form

The comments form is difficult to adapt and needs updating, but apparently theme developers aren’t allowed to use a custom form.

function detectWPMU() {
return function_exists(‘is_site_admin’);
}
…
This function just should be if is_multisite() and that particular function removed completely.
…
… That’s so outdated it’s silly,

Personal comment on how a theme developer codes, wow way to go for impartiality. Backwards compatibility sometimes requires code that you wouldn’t necessarily use. There is nothing wrong with the code, even if it is ‘dated’.

Should also change from using the get_pages in the function _tarski_navbar_page_links to using the wordpress 3.0 menu system

So existing users of theme lose all their settings, well gee that will go down well, NOT.

function tarski_searchform() {
include_once(TEMPLATEPATH . “/searchform.php”);
}
`

should use get_search_form() instead, this is outdated and will fail the review as well

Yes the search form can be amended, but the theme this relates to was being updated, it wasn’t a new one. If it was new I’d agree with the comment – as it’s an update I don’t. there is nothing wrong with that method, it just doesn’t use available hooks etc.

Developing a Theme for WordPress? good for you, want to host it on WordPress.org – if you don’t follow the guidelines to the letter it gets rejected.

I am so glad I don’t develop WordPress themes.